add hostname-override for external aws cloud provider #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superseb
reviewed
Oct 17, 2023
| if echo ${@} | grep -v "hostname-override"; then | ||
| hostname=$(curl "http://169.254.169.254/latest/meta-data/hostname") | ||
| if [ -z "$hostname" ]; then |
There was a problem hiding this comment.
What is a possible reason for hostname to be empty? Should it not retry or log something? We didn't have this when it was only kube-proxy.
There was a problem hiding this comment.
@superseb I haven't seen hostname empty yet, but saw this in rke2 so added it for consistency: https://github.com/rancher/rke2/blob/f8cb409287ac09608d3d2fbac364dddb05400a3e/pkg/rke2/rke2_linux.go#L82
jiaqiluo
requested changes
Oct 17, 2023
superseb
approved these changes
Oct 18, 2023
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rancher/rke#3413 for more details. RKE removes
hostname-overrideforexternal-awswhenuseInstanceMetadataHostnameis enabled so rke-tools sets it as the node name expected by cloud provider.Original issue: rancher/rancher#43175