Merge testing #28
Merged
Merge testing #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally some data copies have been removed. More work still needs to be done to reduce more allocations.
It is possible that writes can starve the ping pong process because a pong requires a write. In that situation the read deadline could not be set. This patch we ensure we update the read deadline on writes to keep the socket open when we are doing heavy writes.
All user facing timeout should be handled at a layer above the connection because the connection is global and shared by everyone. If one was to set a short timeout on a read it could impact a long read/write somewhere else.
Merge commit '6838081e828c56941066d42e5865dc0b0ded8574' into testing Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Add #24 to testing branch via a merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.