Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile all plugins #49

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

thomasferrandiz
Copy link
Contributor

@thomasferrandiz thomasferrandiz commented Apr 30, 2024

xx-go --wrap is not compatible with the build_linux.sh script so the plugins were not actually built.

Related issue: #48

@manuelbuil
Copy link
Contributor

Can you briefly explain in the description how you are fixing the problem?

@thomasferrandiz
Copy link
Contributor Author

The helper script ``xx-gohas 2 modes. The first one is just a wrapper forgo` which sets the right var like `GOOS` to cross-compile properly to `TARGETPLATFORM`.
The second mode (`xx-go --wrap`) changes the GOENV file so that all calls to `go` are set to cross-compile.
I don't know why but this 2nd mode is not compatible which the script `build_linux.sh` from the upstream cni repo.

So I use the 1st mode by calling the build_linux.sh script with the GO var set to xx-go so that alls calls to ${GO:-go} build in the script are set-up to cross-compile when needed.

@thomasferrandiz thomasferrandiz merged commit 778fa1d into rancher:main Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants