Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patchesStrategicMerge for Kustomize patching #41

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

weyfonk
Copy link
Contributor

@weyfonk weyfonk commented Oct 3, 2023

Drop for legacy-style patching was dropped in sigs.k8s.io/kustomize/api v0.13.0, causing Fleet acceptance tests for Kustomize examples to fail (example), with errors such as:

error while running post render on files: invalid Kustomization: json: cannot unmarshal string into Go struct field Kustomization.patches of type types.Patch]

@weyfonk weyfonk requested a review from a team as a code owner October 3, 2023 15:15
@weyfonk weyfonk marked this pull request as draft October 3, 2023 15:17
Drop for legacy patches was dropped [1] in `sigs.k8s.io/kustomize/api`
`v0.13.0`, causing Fleet acceptance tests for Kustomize examples to
fail.

[1]: https://github.com/kubernetes-sigs/kustomize/releases/tag/api%2Fv0.13.0
@weyfonk weyfonk force-pushed the kustomize-drop-legacy-patching branch from 4442b06 to 86f321d Compare October 3, 2023 15:31
@weyfonk weyfonk marked this pull request as ready for review October 3, 2023 15:32
@weyfonk weyfonk merged commit 7045735 into rancher:master Oct 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants