Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy to build media to warn users not to change page + add download btn seed image #205

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Add copy to build media to warn users not to change page + add download btn seed image #205

merged 2 commits into from
Jul 22, 2024

Conversation

aalves08
Copy link
Contributor

Fixes #204

  • add download btn to seedImage list view
  • add note to warn users about navigating out of page when building media images

Screenshots

Screenshot 2024-07-19 at 16 55 50 Screenshot 2024-07-19 at 16 55 46 Screenshot 2024-07-19 at 16 55 42

@aalves08 aalves08 self-assigned this Jul 19, 2024
@aalves08 aalves08 requested a review from jordojordo July 19, 2024 15:58
jordojordo
jordojordo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion with the wording, otherwise lgtm.

pkg/elemental/l10n/en-us.yaml Outdated Show resolved Hide resolved
@aalves08 @jordojordo
Update pkg/elemental/l10n/en-us.yaml
168e5ae 
Co-authored-by: Jordon Leach <40806497+jordojordo@users.noreply.github.com>
@aalves08 aalves08 merged commit 0f27c03 into rancher:main Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordojordo jordojordo jordojordo approved these changes

Assignees

@aalves08 aalves08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add copy to build media to warn users not to change page + add download btn seed image
2 participants
@aalves08 @jordojordo