Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.1.x] Move recovery hostname to cloud-config-defaults #2047

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Apr 17, 2024

Setting recovery hostname is mostly a nice-to-have and can be destructive so move it to cloud-config-defaults feature.

This is a backport to v1.1.x to solve recovery hostname issue in rancher/elemental

Setting recovery hostname is mostly a nice-to-have and can be
destructive so move it to cloud-config-defaults feature.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon requested a review from a team as a code owner April 17, 2024 13:12
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon changed the title Move recovery hostname to cloud-config-defaults [v1.1.x] Move recovery hostname to cloud-config-defaults Apr 17, 2024
@frelon frelon merged commit c20fa28 into rancher:v1.1.x Apr 17, 2024
9 of 12 checks passed
@frelon frelon deleted the backport-recovery-hostname branch April 17, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants