Change location of bootargs.conf #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frelon
force-pushed
the
bootargs-etc-elemental
branch
from
3d99580 to
0a55eb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
=======================================
Coverage 72.56% 72.56%
=======================================
Files 76 76
Lines 8907 8907
=======================================
Hits 6463 6463
Misses 1910 1910
Partials 534 534 ☔ View full report in Codecov by Sentry. |
davidcassany
approved these changes
Mar 15, 2024
| @@ -57,6 +57,12 @@ function set_loopdevice { | |||
| loopback ${volume} ${1} | |||
| } | |||
|
|
|||
| ## Sources bootargs from the current volume | |||
| function source_bootargs { | |||
| source (${volume})/etc/cos/bootargs.cfg | |||
There was a problem hiding this comment.
Isn't this failing if the file is not there? 🤔
There was a problem hiding this comment.
Not when I tried it.. I was going to check if the file existed first but seems like it's not needed 🤷
Use the same location as grub.conf, /etc/elemental. The grub config is backwards compatible and tries to source from /etc/cos/bootargs.conf as well. Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
frelon
force-pushed
the
bootargs-etc-elemental
branch
from
0a55eb9 to
4304a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same location as grub.conf, /etc/elemental.
The grub config is backwards compatible and tries to source from /etc/cos/bootargs.conf as well.