Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines the snapshotter interface and snapshotter configuration structures. I does not provide any implementation of the interface it just provides all the required pieces to read the snapshotter configuration:
Config is defined internally as a
interface{}
and the format and schema ofconfig
depends on thetype
value. This PR essentially provides the structures definition and the logic to unmarshallconfig
depending ontypes
value.In a follow up PR I expect to include the loopdevice implementation and its unit tests (but keeping the interface unused still). Finally in third of forth PR I expect to include the full refactor to actually start using the interface in
install
,reset
andupgrade
, commands. All this is an effort to make PRs easier to follow and review.Part of #1874