Skip to content

Commit

Permalink
seedimage: use ClusterIP Services (#709)
Browse files Browse the repository at this point in the history
When building an ISO, we create a Pod and a Service to expose the built
ISO when ready.
The link to the ISO is then exposed through the Elemental Operator
Deployment, that acts as an Ingress.
The Service we create to expose the Pod port is of type NodePort: this
is not needed,is just a leftover from the initial implementations, where
we usede to expose a "direct" link to the Pod.
No need to keep a NodePort service now, let's have a ClusterIP Service
type instead.

Fixes: #705

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
  • Loading branch information
fgiudici authored Apr 22, 2024
1 parent 47516fd commit a43c150
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion controllers/seedimage_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,6 @@ func fillBuildImageService(name, namespace string) *corev1.Service {
Port: 80,
},
},
Type: corev1.ServiceTypeNodePort,
},
}

Expand Down

0 comments on commit a43c150

Please sign in to comment.