Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure step conditions are respected #473

Merged
merged 1 commit into from
Aug 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions actions/publish-image/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ runs:
# Short-circuit if either fails. This should decrease the likelihood
# of only one registry getting updated while the other fails.
- name: Login to registry [Public]
if: ${{ inputs.push-to-public }}
if: ${{ inputs.push-to-public == true || inputs.push-to-public == 'true' }}
uses: docker/login-action@v3
with:
registry: ${{ inputs.public-registry }}
username: ${{ inputs.public-username }}
password: ${{ inputs.public-password }}

- name: Login to registry [Prime]
if: ${{ inputs.push-to-prime }}
if: ${{ inputs.push-to-prime == true || inputs.push-to-prime == 'true' }}
uses: docker/login-action@v3
with:
registry: ${{ inputs.prime-registry }}
Expand All @@ -155,7 +155,7 @@ runs:

- name: Build and push image [Public]
shell: bash
if: ${{ inputs.push-to-public }}
if: ${{ inputs.push-to-public == true || inputs.push-to-public == 'true' }}
run: |
make ${{ inputs.make-target }}
env:
Expand All @@ -165,7 +165,7 @@ runs:

- name: Build and push image [Prime]
shell: bash
if: ${{ inputs.push-to-prime }}
if: ${{ inputs.push-to-prime == true || inputs.push-to-prime == 'true' }}
run: |
IID_FILE=$(mktemp)
export IID_FILE_FLAG="--iidfile ${IID_FILE}"
Expand Down
Loading