Add annotation to stop upgrades for managed charts #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
mantis-toboggan-md
approved these changes
Apr 7, 2022
|
That issue should be rancher/partner-charts#220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Phillip Rak rak.phillip@gmail.com
Summary
This prepares for a new annotation that will be added to managed charts in k3s. We'll keep the check for
FLEET.BUNDLE_IDbecause new annotation is expected to come at a later date and we don't want to change existing behavior.Fixes #4442
See #4621 for previous attempt and more discussion
Technical notes summary
The new
catalog.cattle.io/managedannotation will be added to k3s at a later date. Existing behavior should be unchanged for now.Areas or cases that should be tested
If you go into
Installed AppsinApps and Marketplace, the upgrade options should be unchanged.Areas which could experience regressions
Installed AppsinApps and Marketplace