Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 2.10] Match Harvester community repo check via regex #13212

Merged
merged 2 commits into from
Jan 27, 2025
Merged

[backport 2.10] Match Harvester community repo check via regex #13212

merged 2 commits into from
Jan 27, 2025

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 27, 2025 •
edited
Loading

Summary

Fixes #13203

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@torchiaf
Match Harvester community repo check via regex
9f71f88 
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf requested a review from aalves08 January 27, 2025 13:33
@torchiaf torchiaf added this to the v2.10.2 milestone Jan 27, 2025
aalves08
aalves08 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf changed the title [2.10] Match Harvester community repo check via regex [backport 2.10] Match Harvester community repo check via regex Jan 27, 2025
@torchiaf
Fix missing await async calls; Remove this.harvesterRepository assign…
be3ee30 
…ement to avoid PUT conflict

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
aalves08
aalves08 approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit da5c6f2 into rancher:release-2.10 Jan 27, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalves08 aalves08 aalves08 approved these changes

Assignees

@torchiaf torchiaf

Labels
None yet
Projects
None yet
Milestone
v2.10.2
Development

Successfully merging this pull request may close these issues.
2 participants
@torchiaf @aalves08