Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling to extension load #13204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

Add error handling to extension load #13204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions shell/core/plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ export default function(context, inject, vueApp) {

removed.then(() => {
element.onload = () => {
if (!window[id]) {
if (!window[id] || (typeof window[id].default !== 'function')) {
return reject(new Error('Could not load plugin code'));
}

Expand All @@ -113,7 +113,13 @@ export default function(context, inject, vueApp) {
plugins[id] = plugin;

// Initialize the plugin
window[id].default(plugin, this.internal());
try {
window[id].default(plugin, this.internal());
} catch (e) {
delete plugins[id];

return reject(new Error('Could not initialize plugin'));
}

// Uninstall existing plugin if there is one
this.removePlugin(plugin.name); // Removing this causes the plugin to not load on refresh
Expand Down
Loading