Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aks region being overwritten when editing unprovisioned aks clusters #13037

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11841

This bug is specific to AKS clusters that have been created in Rancher, but not yet created in AKS. To repro, you can use the default AKS configuration options (except region) but you need to edit the cluster immediately after creating it to see the bug. This PR tweaks some login in the location-fetching method that failed to account for this inbetweeny edit mode.

Areas or cases that should be tested

  1. Create a new AKS cluster - after entering in credentials, regions should be loaded and east us selected by default.
  2. Change the region to something else
  3. Set other required fields and save
  4. immediately edit the cluster. The region dropdown should show whatever region you picked in step 2. If you open the dropdown, you should see a list of regions to select.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md removed the request for review from jordojordo January 9, 2025 23:23
@mantis-toboggan-md mantis-toboggan-md marked this pull request as draft January 9, 2025 23:23
@mantis-toboggan-md mantis-toboggan-md marked this pull request as ready for review January 10, 2025 00:53
@mantis-toboggan-md mantis-toboggan-md merged commit 938b866 into rancher:master Jan 10, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AKS region changes in Edit Mode
2 participants