Handle correctDrift:enabled undefined value #13029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
aalves08
reviewed
Jan 10, 2025
| @@ -648,12 +653,13 @@ export default { | |||
| <h2 v-t="'fleet.gitRepo.resources.label'" /> | |||
| <div> | |||
| <Checkbox | |||
| v-model:value="value.spec.correctDrift.enabled" | |||
| v-model:value="correctDriftEnabled" | |||
There was a problem hiding this comment.
I couldn't repro this issue, although I didn't provision a rancher system from that commit, tbh.
My question is: Using v-model and @update:value to set the exact same variable value doesn't yield any problems on the console/UI?
We do either https://github.com/rancher/dashboard/blob/master/pkg/gke/components/AdvancedOptions.vue#L179-L184 or https://github.com/rancher/dashboard/blob/master/pkg/gke/components/AdvancedOptions.vue#L169-L173 but I don't think we should do both 🤔
The rest LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13026
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist