Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature flag restart terminology #13024

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jan 9, 2025

Summary

Fixes #11305

Occurred changes and/or fixed issues

This PR renames the column name on the feature flag page and also the message in the confirmation modal.

The terminology now is 'Restart Rancher' (where 'Rancher' is the vendor name)

Technical notes summary

Table columns only accept a label key which can not have params, so we evaluate the table header with the vendor name when we add the table headers for the feature flag table.

Areas or cases that should be tested

  1. Visually check that the column name has changed.
  2. Try and activate/deactivate a feature flag that requires restart and check the message is correctly updated.

Screenshot/Video

List, showing new name for list column for restart:

image

Modal dialog for activate/de-activate:

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.11.0 milestone Jan 9, 2025
@nwmac nwmac requested a review from aalves08 January 9, 2025 15:49
aalves08
aalves08 previously approved these changes Jan 9, 2025
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac force-pushed the fix-feature-flag-restart-terminology branch from d68b7d9 to fcd7fac Compare January 13, 2025 11:27
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 5ab53f3 into rancher:master Jan 13, 2025
32 checks passed
@nwmac nwmac deleted the fix-feature-flag-restart-terminology branch January 13, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature flag changes: clarify what exactly "restart" means
2 participants