Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top-level burger menu keyboard navigation #12876

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Dec 12, 2024

Summary

Fixes #12769

Occurred changes and/or fixed issues

This PR adds keyboard navigation support to the top-left app bar hamburger menu.

Areas or cases that should be tested

Load the UI, press the Tab key - you will see focus indication on the menu icon.

You can now press SPACE or ENTER to expand/collapse the button.

This also adds the aria-label and role attributes to the button.

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@nwmac nwmac requested a review from aalves08 December 18, 2024 11:43
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Neil. Let's get this first one in, so that we can build on top of this app-wide focus style 🙏

@nwmac nwmac merged commit 6fd149c into rancher:master Dec 18, 2024
29 checks passed
@nwmac nwmac deleted the fix-app-bar-burger-menu branch December 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: Fix keyboard navigation, aria-label, role and focus display for top-left hamburger menu
2 participants