Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typegen path fix #12228

Merged

Conversation

aalves08
Copy link
Collaborator

Summary

Fixes #12226

When running the publish-shell workflow the typegen script would not include the necessary typescript definitions for the @rancher/shell library.

The issue was caused by incorrectly referencing the shell directory within the runner. When the script is ran locally there is no issue as the shell directory is accessible. However, within a workflow runner the shell directory was in a different location.

Occurred changes and/or fixed issues

  • Replaced the BASE_DIR value to use git rev-parse --show-toplevel to ensure the correct repository level regardless of the runner's current working directory.
  • Replaced the shell/* directory matching when running the tsc command to SHELL_DIR which is accessible to the worker.
  • Added a log of the contents within the ${SHELL_DIR}/tmp directory.

Areas or cases that should be tested

  • Publishing a shell package

Asuccessful test run can be found within my fork actions along with the artifact containing the correct index.d.ts

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 self-assigned this Oct 11, 2024
@aalves08 aalves08 added this to the v2.8.9 milestone Oct 11, 2024
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eva-vashkevich eva-vashkevich merged commit 6c1e904 into rancher:release-2.8 Oct 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants