Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12226
When running the publish-shell workflow the typegen script would not include the necessary typescript definitions for the
@rancher/shell
library.The issue was caused by incorrectly referencing the shell directory within the runner. When the script is ran locally there is no issue as the
shell
directory is accessible. However, within a workflow runner theshell
directory was in a different location.Occurred changes and/or fixed issues
BASE_DIR
value to usegit rev-parse --show-toplevel
to ensure the correct repository level regardless of the runner's current working directory.shell/*
directory matching when running thetsc
command toSHELL_DIR
which is accessible to the worker.${SHELL_DIR}/tmp
directory.Areas or cases that should be tested
Asuccessful test run can be found within my fork actions along with the artifact containing the correct
index.d.ts
Checklist