Fix reference to tsc binary when publishing shell #12176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordojordo
changed the title
jordojordo
added a commit
to jordojordo/dashboard
that referenced
this pull request
Oct 9, 2024
* Fix BASE_DIR path * Add pipefail for proper error handling
jordojordo
added a commit
to jordojordo/dashboard
that referenced
this pull request
Oct 9, 2024
* Fix BASE_DIR path * Add pipefail for proper error handling
jordojordo
added a commit
that referenced
this pull request
Oct 10, 2024
) * Fix reference to tsc binary when publishing shell (#12176) * Fix BASE_DIR path * Add pipefail for proper error handling * Bump shell package 1.2.5-rc.2
nwmac
pushed a commit
to nwmac/dashboard
that referenced
this pull request
Oct 24, 2024
* Fix BASE_DIR path * Add pipefail for proper error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12147
The
node_modules/.binis no longer accessible due to a typo within theBASE_DIRvariableOccurred changes and/or fixed issues
&with a double&&in both publish-shell.sh and typegen.sh scriptspipefailtopublish-shellscript to ensure it will exit when a command has an errorTechnical notes summary
Using a single ampersand & instead of a double ampersand && will run the preceding command in the background rather than sequentially.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist