Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag changes: clarify what exactly "restart" means #11305

Open
moio opened this issue Jun 27, 2024 · 0 comments · May be fixed by #13024
Open

Feature flag changes: clarify what exactly "restart" means #11305

moio opened this issue Jun 27, 2024 · 0 comments · May be fixed by #13024
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Milestone

Comments

@moio
Copy link
Contributor

moio commented Jun 27, 2024

Setup

  • Rancher version: any, tested in 2.9.0-alpha5
  • Rancher UI Extensions: none
  • Browser type & version: any, tested in Firefox 127.0.1 (64-bit)

Describe the bug
Current wording on Rancher restarts and warnings could be made clearer.

Feedback came from a Support KT about the new caching/pagination features (internal reference).

To Reproduce

Navigate to Global settings -> Feature flags. Try activating or deactivating a feature which requires restart

Result / Expected Result / Screenshots

Currently:
image

Wording of the header does not make it clear that Rancher will restart itself - on a first read users might be confused it's on them to restart Rancher after activating/deactivating.

Suggestion: change the title to "Rancher automatically restarts on change" or similar.

Currently, upon activation/deactivation the following popup appears:
image

Wording does not convey this will immediately restart all Rancher containers at the same time, therefore immediately causing downtime until containers are up again. Users might assume that Rancher pods are recycled one at a time levering Rancher's HA, but that is not the case for now.

Suggestions: 1) change the wording of the note to:

"Note: proceeding will immediately restart all Rancher containers, therefore causing Rancher downtime until they are ready again."

  1. consider using a "warning" instead of a "note"

  2. change the button text to "Activate and Restart"

@moio moio added the kind/bug label Jun 27, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jun 27, 2024
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jun 30, 2024
@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@nwmac nwmac self-assigned this Jan 8, 2025
@nwmac nwmac added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jan 9, 2025
@nwmac nwmac linked a pull request Jan 9, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants