Add Azure ClusterClass #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
force-pushed
the
add_azure_cluster_class
branch
from
311a78a to
3fdcd18
Compare
anmazzotti
force-pushed
the
add_azure_cluster_class
branch
4 times, most recently
from
64ebc43 to
5644bf1
Compare
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
anmazzotti
force-pushed
the
add_azure_cluster_class
branch
from
5644bf1 to
976edf7
Compare
There was a problem hiding this comment.
Thanks @anmazzotti. The content of the PR LGTM. If you're okay with it, let's first find an agreement on what we discussed on #586 and then we can move with merging both PRs.
|
Closing this PR in favor of rancher/turtles#1121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a ClusterClass generic example for RKE2 on Azure.
It allows the user to provision a simple cluster using Community images.
It supports generic but sizeable MachineDeployments.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: