Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.28] [v2.8] Update indirect dependencies to point to respective release-v2.8 branch #405

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

chiukapoor
Copy link
Contributor

Issue

  • Some indirect dependency tag were pointing to release-v2.9 branch

Update

  • Revert 8db2fb9
  • Update indirect dependencies to match release-v2.8

Related

Signed-off-by: Chirayu Kapoor <chirayu.kapoor@suse.com>
@chiukapoor chiukapoor requested a review from a team as a code owner February 14, 2024 14:44
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick

@@ -72,17 +72,17 @@ require (
github.com/prometheus/client_model v0.4.0 // indirect
github.com/prometheus/common v0.44.0 // indirect
github.com/prometheus/procfs v0.10.1 // indirect
github.com/rancher/eks-operator v1.4.0-rc1 // indirect
github.com/rancher/eks-operator v1.3.1-rc1 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency should be removed

github.com/rancher/fleet/pkg/apis v0.0.0-20231017140638-93432f288e79 // indirect
github.com/rancher/gke-operator v1.3.0-rc2 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency should be removed

@mjura mjura merged commit 8e23ef9 into rancher:release-v2.8 Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants