-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable AKS to use Outbound type of userDefinedRouting #163
Conversation
@alexander-demicev kindly review |
@@ -97,7 +106,7 @@ func createManagedCluster(ctx context.Context, cred *Credentials, workplacesClie | |||
logrus.Warnf("loadBalancerSKU 'basic' is not supported") | |||
networkProfile.LoadBalancerSku = containerservice.Basic | |||
case "": | |||
networkProfile.LoadBalancerSku = containerservice.Standard | |||
networkProfile.LoadBalancerSku = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major comment, but curious why we need to remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@furkatgofurov7 ,
Operator creates a standard loadbalancer (egress) by default, by removing this, I will not have egress created by uses pre-defined route table for egress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about that, but I am going to test it
@mjura you're the most experienced, please also take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it has to be tested
@@ -97,7 +106,7 @@ func createManagedCluster(ctx context.Context, cred *Credentials, workplacesClie | |||
logrus.Warnf("loadBalancerSKU 'basic' is not supported") | |||
networkProfile.LoadBalancerSku = containerservice.Basic | |||
case "": | |||
networkProfile.LoadBalancerSku = containerservice.Standard | |||
networkProfile.LoadBalancerSku = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about that, but I am going to test it
Testing in progress .... |
After some few test runs I see that example-configuration isn't complete:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still needs more testing and corrections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it needs some changes
spec: | ||
resourceLocation: "germanywestcentral" | ||
resourceGroup: "my-group" | ||
clusterName: "my-cluster" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is missing dnsPrefix: "example-string"
Will cherry-pick and add fixes |
We will continue there #189 |
PR #189 was merged |
With UDR setup, there is no need to provision loadbalancer for
egress
communication. Egress will be routed to existing route table in the VNET/Subnet.This will be useful in the setup where creation of public loadbalancer is prohibited.