Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AKS to use Outbound type of userDefinedRouting #163

Closed
wants to merge 1 commit into from

Conversation

rajan2
Copy link
Contributor

@rajan2 rajan2 commented Mar 25, 2023

With UDR setup, there is no need to provision loadbalancer for egress communication. Egress will be routed to existing route table in the VNET/Subnet.
This will be useful in the setup where creation of public loadbalancer is prohibited.

@rajan2
Copy link
Contributor Author

rajan2 commented Mar 29, 2023

@alexander-demicev kindly review

@rajan2
Copy link
Contributor Author

rajan2 commented Apr 3, 2023

@mjura

@@ -97,7 +106,7 @@ func createManagedCluster(ctx context.Context, cred *Credentials, workplacesClie
logrus.Warnf("loadBalancerSKU 'basic' is not supported")
networkProfile.LoadBalancerSku = containerservice.Basic
case "":
networkProfile.LoadBalancerSku = containerservice.Standard
networkProfile.LoadBalancerSku = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comment, but curious why we need to remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@furkatgofurov7 ,
Operator creates a standard loadbalancer (egress) by default, by removing this, I will not have egress created by uses pre-defined route table for egress.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that, but I am going to test it

@kkaempf kkaempf requested a review from mjura April 26, 2023 14:12
@kkaempf
Copy link

kkaempf commented Apr 26, 2023

@mjura you're the most experienced, please also take a look.

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it has to be tested

@@ -97,7 +106,7 @@ func createManagedCluster(ctx context.Context, cred *Credentials, workplacesClie
logrus.Warnf("loadBalancerSKU 'basic' is not supported")
networkProfile.LoadBalancerSku = containerservice.Basic
case "":
networkProfile.LoadBalancerSku = containerservice.Standard
networkProfile.LoadBalancerSku = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about that, but I am going to test it

@mjura
Copy link
Contributor

mjura commented Apr 28, 2023

Testing in progress ....

@mjura mjura self-assigned this Apr 28, 2023
@mjura
Copy link
Contributor

mjura commented Apr 28, 2023

After some few test runs I see that example-configuration isn't complete:

ERRO[1061] error syncing 'cattle-global-data/mjura-outb': handler aks-controller: error failed to create cluster: containerservice.ManagedClustersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="EmptySubnetError" Message="The input subnet is an empty string." , requeuing 

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still needs more testing and corrections

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it needs some changes

spec:
resourceLocation: "germanywestcentral"
resourceGroup: "my-group"
clusterName: "my-cluster"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is missing dnsPrefix: "example-string"

@kkaempf
Copy link

kkaempf commented May 2, 2023

Will cherry-pick and add fixes

@mjura
Copy link
Contributor

mjura commented May 3, 2023

We will continue there #189

@mjura
Copy link
Contributor

mjura commented May 3, 2023

PR #189 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants