Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-environment support for AKS #136

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Add multi-environment support for AKS #136

merged 1 commit into from
Apr 8, 2023

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Feb 21, 2023 •
edited by a-blender
Loading

Issue: #98

(cherry picked from commit 41a68e8)

This was referenced Feb 21, 2023
Closed
Closed
@smallteeths @mjura
Add multi-environment support for AKS
d95dafb 
Fixes: rancher#98

(cherry picked from commit 41a68e8)
@mjura mjura requested review from alexander-demicev, jakefhyde and a-blender and removed request for alexander-demicev February 24, 2023 08:30
@mjura mjura marked this pull request as ready for review February 24, 2023 08:31
richardcase
richardcase approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

pkg/aks/client.go Show resolved Hide resolved
a-blender
a-blender approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@a-blender a-blender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this tested?

@mjura
Copy link
Contributor Author

mjura commented Mar 3, 2023

How was this tested?

Thank you for asking. This change wasn't tested or it was tested on AzurePublicCloud. We need someone who has access to gov cloud to test it

alexander-demicev
alexander-demicev approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
testing on govcloud will require someone with access to it or a partnership with Microsoft, I know they can provide a simulator.

@mjura mjura merged commit bf04b15 into rancher:master Apr 8, 2023
@mjura mjura deleted the azure-gov branch July 23, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase richardcase approved these changes

@a-blender a-blender a-blender approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@jakefhyde jakefhyde Awaiting requested review from jakefhyde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mjura @richardcase @a-blender @alexander-demicev @Jono-SUSE-Rancher @Sahota1225 @thatmidwesterncoder @smallteeths