Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add idempotency to create product API #88

Merged
merged 2 commits into from
Oct 9, 2023
Merged

feature: add idempotency to create product API #88

merged 2 commits into from
Oct 9, 2023

Conversation

ran-isenberg
Copy link
Owner

Summary

  • add idempotency to create product API
  • added e2e tests
  • removed duplicate product model definition

User experience

If applicable, please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • PR title follows conventional commit semantics
Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@ran-isenberg
Copy link
Owner Author

@heitorlessa pretty sure this is an idempotency issue. i had to do an ugly inner import trick

@ran-isenberg ran-isenberg temporarily deployed to dev October 8, 2023 20:37 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2dd0cef) 97.95% compared to head (27cf9da) 98.30%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   97.95%   98.30%   +0.35%     
==========================================
  Files          34       32       -2     
  Lines         537      532       -5     
==========================================
- Hits          526      523       -3     
+ Misses         11        9       -2     
Files Coverage Δ
product/crud/domain_logic/create_product.py 100.00% <100.00%> (ø)
product/crud/domain_logic/delete_product.py 100.00% <100.00%> (ø)
product/crud/domain_logic/get_product.py 100.00% <100.00%> (ø)
product/crud/domain_logic/list_products.py 100.00% <100.00%> (ø)
product/crud/handlers/constants.py 100.00% <100.00%> (ø)
product/crud/handlers/handle_create_product.py 100.00% <100.00%> (ø)
product/crud/handlers/handle_delete_product.py 100.00% <100.00%> (ø)
product/crud/handlers/handle_get_product.py 100.00% <100.00%> (ø)
product/crud/handlers/handle_list_products.py 100.00% <100.00%> (ø)
product/crud/handlers/utils/rest_api_resolver.py 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ran-isenberg ran-isenberg temporarily deployed to dev October 9, 2023 16:01 — with GitHub Actions Inactive
@ran-isenberg ran-isenberg merged commit 7b1d8c9 into main Oct 9, 2023
7 checks passed
@ran-isenberg ran-isenberg deleted the idem branch October 9, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant