Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scroll to contact form #67

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

dnlnashed
Copy link
Member

@dnlnashed dnlnashed commented Aug 29, 2023

Related: #66

The "Get in Touch" and "Request a demo" button will now properly scroll to the contact form.
This change also prevents any unnecessary map rendering when quickly scrolling past a feature,


This change is Reviewable

@github-actions
Copy link

Your demo site is ready! 🚀

Main: https://ramp4-pcar4.github.io/ramp-website/contact-scroll/

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dnlnashed)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dnlnashed)

@szczz szczz merged commit bc62273 into ramp4-pcar4:master Aug 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants