Test enhancement #62
Test enhancement #62
Conversation
composer.json
Outdated
| "require": { | ||
| "php": ">=5.5.0", | ||
| "ext-mbstring": "*" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "4.*" | ||
| "phpunit/phpunit": "^4.8 || ^5.7 || ^6.5" |
There was a problem hiding this comment.
Is there any reason for this? I think you should just bump it to >=6 ...
There was a problem hiding this comment.
@adelowo, you're right. I just set the ^6.5 version to support the php-7.0+ versions :).
tests/bootstrap.php
Outdated
| <?php | ||
|
|
||
| require_once __DIR__ . '/../vendor/autoload.php'; | ||
| require_once __DIR__ . '/Fixtures/Even.php'; |
There was a problem hiding this comment.
Haven't written PHP in a long time but I remember that if you set up require-dev ( which you have), you don't have to manually require files except vendor/autoload.php.
Before tests are run, composer install --dev command is issued so it should take care of the autoloading.
There was a problem hiding this comment.
Yeah, I almost forgot that. I only need to do is loading the vendor/autoload.php and don't load that files you mention manually because of namespace definition.
|
LGTM... Using the namespaced version of PHPUnit is just awesome. |
peter279k
force-pushed
the
test_enhancement
branch
from
6adedfa to
aa5f9c9
Compare
|
Hi @adelowo, thank you for your review :). I appreciate your help. I've done for the request changes that you mention. |
Sure thing @peter279k ... You'd have to wait on @emsifa |
|
I merge this to v1 branch. Thank you. |
Changed log
php-5.5andphp-5.6versions support because these PHP versions will be end of life.testsfolder.tests/bootstrap.phpfile to load the all required files once before doing unit test work.