AWS.GenerateSTSCredentialsAsync() should use GET instead of POST (according to vault docs)

[icanhasjonas]

Turns out VaultSharp is using a non-standard access method for generating AWS STS access tokens. The documentation says GET https://www.vaultproject.io/api-docs/secret/aws#generate-credentials but VaultSharp today uses a POST call

[megakid]

@rajanadar Would it be possible to get this merged and a release created?

I've created an internal forked release in the meantime but would be nice to get back to using the main project.

[Marusyk]

@megakid no so far )))
#118
Usually, @rajanadar disappears for a long time

[rajanadar]

thanks @icanhasjonas for the PR.
thanks @rkrasiuk and @Marusyk for approving.
thanks @hoerup for merging.

@megakid I have published a new version with this fix. Please test and let me know if any issues.
https://www.nuget.org/packages/VaultSharp/1.4.0.6

[rajanadar]

@megakid no so far )))
#118
Usually, @rajanadar disappears for a long time

@Marusyk

Let me explain one last time, since human beings exist under different context.
I had a family emergency. My daughter was born 3 months prematurely and it was a different 6 months of life.
I cannot assume that you folks would know what's happening with me. Hence I have to inform you folks if it needs to be a fair and empathetic conversation. Especially to a couple of folks who have really spent time and effort on this project. Thanks @hoerup for being awesome. I can totally relate to what it would feel to be in your shoes.

I respect all the time and effort in your contribution for this project. And your feedback and dedication.
I don't want to quarrel or have a hostile back n forth or any negative conversation. Life is too short for it. 👍

So I am hoping that, this is the last time we have wisecrack statements or taunts :). From one student of software to another. Have a great day! Cheers.

[Marusyk]

@rajanadar
Sorry, but we are not interested in your problems. Everyone has problems.
We just need the support of this library!

If you can't do that, let others do it

[megakid]

@Marusyk that is very harsh and uncalled for. This is an open source library, not something that you should expect support for.

@rajanadar sorry to hear about your emergency- I hope things are going ok now. I appreciate you spending the time to get a new release out, I will try to test it next week.

[Marusyk]

Look @megakid, you don't know the full history since 2019!
I think GitHub is the wrong place for complaints.
I have a family problem too. Should I describe it in the PR comments? Not sure

I'm not talking about direct support.
If you are the author of a library and do not have time to maintain it, when the community requires it, just let them know and let others do it. Otherwise, it's not respect for the community that uses your library!

What do you think @rajanadar?

[rajanadar]

thanks @megakid. Please let me know if you see any issue.