Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fork of VaultSharp #118

Closed
hoerup opened this issue Feb 7, 2020 · 8 comments
Closed

New fork of VaultSharp #118

hoerup opened this issue Feb 7, 2020 · 8 comments

Comments

@hoerup
Copy link
Collaborator

hoerup commented Feb 7, 2020

A few of us Vaultsharp users got impatient with the lack of progress here, so we have created a fork of VaultSharp to be found here: https://github.com/VaultSharp/VaultSharp/

Please note that we really appreciate the work of @rajanadar and we welcome him to collaborate if he again wants to participate in the vaultsharp community.

Since the VaultSharp package on nuget.org is owned by @rajanadar we could not publish the fork under the old name, so the fork is published under the name "VaultSharp.vNext" : https://www.nuget.org/packages/VaultSharp.vNext/

@seif
Copy link
Contributor

seif commented Feb 13, 2020

👍 thanks! @rajanadar Would be good to get access to push to nuget

@rajanadar
Copy link
Owner

thanks @hoerup and @Marusyk

First, I thank you for the support. Second, I apologize for the break. Had a personal medical emergency for a few months. Irrespective of that, I should have added collaborators to this project. I have now added both of you, so that this doesn't happen again EVER.

The plan is as follows.

  1. I have already fixed and added several critical open issues, including ones in VaultSharp/VaultSharp
  2. In a day, I'll publish 0.11.x version to get that out of the way.
  3. I want to spend some time, to figure out how to give you NuGet package permissions as well, if needed.
  4. Finally, we can move onto the non-critical issues and progress on it, as a community.

Thanks.

@Marusyk
Copy link
Collaborator

Marusyk commented Apr 22, 2020

Hello @rajanadar, glad to hear from you. Hope you are doing well.

What do you think about completely moving it to VaultSharp organization? You will have Admin permissions there.

In this way, the community will be able to support the project when you (or any of us) are busy. The organization is a great place to start.

If you reject, I think, we will continue to work on the separate package to avoid such situations. But let's do cool things together. This is Open Source, your great idea with VaultSharp already have a community, and we ready to help you to improve it.

What do you think?

@rajanadar
Copy link
Owner

At this point, there is the full history of the project in this repo, along with all issues, right NuGet package names, the documentation website and also closing down on a million download. I am full steam on 1.4.x efforts starting next week.

I have a lot of other colleagues and projects who work off my fork as well. I would love to not disrupt them.

I totally understand the concern of another break, and am ready to make you and any number of other folks who were active and passionate, as collaborators to avoid this issue in the future.

@Marusyk
Copy link
Collaborator

Marusyk commented Apr 22, 2020

@rajanadar

You always can move this project with the full history of the project in this repo, along with all issues to organization. What is the problem?
I don't say to delete the project, I suggest to open it for community

I totally understand the concern of another break, and am ready to make you and any number of other folks who were active and passionate, as collaborators to avoid this issue in the future.

I think it is a little bit late. If you don't want community help, then why do you put this project to OpenSource?

I am full steam on 1.4.x efforts starting next week.

really? I can show you my PR, with the text "Let me look at this in a couple of days". It will take almost a year :(

I have a lot of other colleagues and projects who work off my fork as well. I would love to not disrupt them.

I say again, we are not going to break this project!!! and package!!

We will move it to the organization and continue to develop it with you

@rajanadar
Copy link
Owner

@Marusyk,
Lets talk offline.

@Marusyk
Copy link
Collaborator

Marusyk commented Apr 22, 2020

@rajanadar what do you mean?

@Marusyk
Copy link
Collaborator

Marusyk commented Nov 18, 2020

image
@rajanadar what about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants