Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject HttpClient using a delegate #135

Closed
rajanadar opened this issue Apr 28, 2020 · 0 comments
Closed

Inject HttpClient using a delegate #135

rajanadar opened this issue Apr 28, 2020 · 0 comments
Assignees
@rajanadar
Labels
enhancement
Milestone
1.4.0.2

Comments

@rajanadar
Copy link
Owner

Currently, the httpClient is an additional parameter that breaks the pattern a bit, by ignoring the handler, adding extra constructor params, duplicating code etc.

The delegate way keeps it clean and simple, and allows the user to not worry about Vault specific stuff.
@rajanadar rajanadar added this to the vnext milestone Apr 28, 2020
@rajanadar rajanadar self-assigned this Apr 28, 2020
rajanadar added a commit that referenced this issue Apr 28, 2020
@rajanadar
doc for #135
8f87877
rajanadar added a commit that referenced this issue May 7, 2020
@rajanadar
bug fix on #135
c564870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajanadar rajanadar

Labels
enhancement
Projects
None yet
Milestone
1.4.0.2
Development

No branches or pull requests
1 participant
@rajanadar