Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: minEnclosingCircle #285

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Fix: minEnclosingCircle #285

merged 4 commits into from
Nov 4, 2024

Conversation

rainyl
Copy link
Owner

@rainyl rainyl commented Nov 3, 2024

fix: #284 #282

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (c904dcf) to head (ac3ad40).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #285   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files          49       49           
  Lines        9129     9129           
=======================================
  Hits         8402     8402           
  Misses        727      727           
Flag Coverage Δ
unittests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainyl rainyl changed the title bump dartcv to 4.10.0.5 [Android] Remove debug info in release build to reduce package size Nov 3, 2024
@rainyl rainyl changed the title [Android] Remove debug info in release build to reduce package size Fix: minEnclosingCircle Nov 3, 2024
@rainyl
Copy link
Owner Author

rainyl commented Nov 3, 2024

Unable to strip library '.../build/app/intermediates/merged_native_libs/release/out/lib/armeabi-v7a/libdartcv.so' due to missing strip tool for ABI 'ARMEABI_V7A'. Packaging it as is.

It's because the ndk used to strip not exists, maybe we should specify the ndk version in opencv_core/android/build.gradle

@rainyl
Copy link
Owner Author

rainyl commented Nov 3, 2024

android.ndkVersion is unavailable in android/build.gradle when building the example... I think it's a bug of Flutter or gradle.

@rainyl rainyl linked an issue Nov 3, 2024 that may be closed by this pull request
@abdelaziz-mahdy
Copy link
Contributor

wow thats a very nice reduction of the package size

@abdelaziz-mahdy
Copy link
Contributor

btw do you know how to reduce windows and linux package sizes too? specially for the opencv_dart one like a minimal version of ffmpeg

@rainyl
Copy link
Owner Author

rainyl commented Nov 4, 2024

btw do you know how to reduce windows and linux package sizes too? specially for the opencv_dart one like a minimal version of ffmpeg

FFMPEG for windows and linux are downloaded from https://github.com/rainyl/FFmpeg-Builds/releases , so it's necessary to configure the build flags properly if we want to reduce the size of ffmpeg.

@rainyl rainyl merged commit acc808f into main Nov 4, 2024
@rainyl rainyl deleted the fix-cv_minEnclosingCircle branch November 4, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

X and Y axis inversion when drawing a circle using the circle function package size question
3 participants