forked from GoogleCloudPlatform/magic-modules
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
VmwareengineExternalAddress and `VmwareengineExternalAccessRule…
…` sweepers, refactor `VmwareengineCluster` sweeper to use shared function (GoogleCloudPlatform#11069)
- Loading branch information
1 parent
45cb4fe
commit ef03c98
Showing
6 changed files
with
349 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
145 changes: 145 additions & 0 deletions
145
...rty/terraform/services/vmwareengine/resource_vmwareengine_external_access_rule_sweeper.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package vmwareengine | ||
|
|
||
| import ( | ||
| "context" | ||
| "log" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform-provider-google/google/envvar" | ||
| "github.com/hashicorp/terraform-provider-google/google/sweeper" | ||
| "github.com/hashicorp/terraform-provider-google/google/tpgresource" | ||
| transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport" | ||
| ) | ||
|
|
||
| func init() { | ||
| sweeper.AddTestSweepers("VmwareengineExternalAccessRule", testSweepVmwareengineExternalAccessRule) | ||
| } | ||
|
|
||
| // At the time of writing, the CI only passes us-central1 as the region | ||
| func testSweepVmwareengineExternalAccessRule(region string) error { | ||
| resourceName := "VmwareengineExternalAccessRule" | ||
| log.Printf("[INFO][SWEEPER_LOG] Starting sweeper for %s", resourceName) | ||
|
|
||
| config, err := sweeper.SharedConfigForRegion(region) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error getting shared config for region: %s", err) | ||
| return err | ||
| } | ||
|
|
||
| err = config.LoadAndValidate(context.Background()) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error loading: %s", err) | ||
| return err | ||
| } | ||
|
|
||
| t := &testing.T{} | ||
| billingId := envvar.GetTestBillingAccountFromEnv(t) | ||
|
|
||
| // List of location values includes: | ||
| // * zones used for this resource type's acc tests in the past | ||
| // * the 'region' passed to the sweeper | ||
| locations := []string{region, "us-central1", "southamerica-west1", "me-west1"} | ||
| log.Printf("[INFO][SWEEPER_LOG] Sweeping will include these locations: %v.", locations) | ||
| for _, location := range locations { | ||
|
|
||
| // Setup variables to replace in list template | ||
| d := &tpgresource.ResourceDataMock{ | ||
| FieldsInSchema: map[string]interface{}{ | ||
| "project": config.Project, | ||
| "region": location, | ||
| "location": location, | ||
| "zone": location, | ||
| "billing_account": billingId, | ||
| }, | ||
| } | ||
|
|
||
| log.Printf("[INFO][SWEEPER_LOG] looking for parent resources in location '%s'.", location) | ||
|
|
||
| parentResponseField := "networkPolicies" | ||
| parentListUrlTemplate := "https://vmwareengine.googleapis.com/v1/projects/{{project}}/locations/{{location}}/networkPolicies" | ||
| parentNames, err := sweeper.ListParentResourcesInLocation(d, config, parentListUrlTemplate, parentResponseField) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error finding parental resources in location %s: %s", location, err) | ||
| continue | ||
| } | ||
|
|
||
| for _, parent := range parentNames { | ||
|
|
||
| // `parent` will be string of form projects/my-project/locations/us-central1-a/privateClouds/my-cloud | ||
| // Change on each loop, so new value used in tpgresource.ReplaceVars | ||
| d.Set("parent", parent) | ||
|
|
||
| listTemplate := "https://vmwareengine.googleapis.com/v1/{{parent}}/externalAccessRules" | ||
| listUrl, err := tpgresource.ReplaceVars(d, config, listTemplate) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error preparing sweeper list url: %s", err) | ||
| return nil | ||
| } | ||
|
|
||
| res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{ | ||
| Config: config, | ||
| Method: "GET", | ||
| Project: config.Project, | ||
| RawURL: listUrl, | ||
| UserAgent: config.UserAgent, | ||
| }) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] Error in response from request %s: %s", listUrl, err) | ||
| return nil | ||
| } | ||
|
|
||
| resourceList, ok := res["externalAccessRules"] | ||
| if !ok { | ||
| log.Printf("[INFO][SWEEPER_LOG] Nothing found in response.") | ||
| return nil | ||
| } | ||
|
|
||
| rl := resourceList.([]interface{}) | ||
|
|
||
| log.Printf("[INFO][SWEEPER_LOG] Found %d items in %s list response.", len(rl), resourceName) | ||
| // Keep count of items that aren't sweepable for logging. | ||
| nonPrefixCount := 0 | ||
| for _, ri := range rl { | ||
| obj := ri.(map[string]interface{}) | ||
| if obj["name"] == nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] %s resource name was nil", resourceName) | ||
| return nil | ||
| } | ||
|
|
||
| name := tpgresource.GetResourceNameFromSelfLink(obj["name"].(string)) | ||
| // Skip resources that shouldn't be sweeped | ||
| if !sweeper.IsSweepableTestResource(name) { | ||
| nonPrefixCount++ | ||
| continue | ||
| } | ||
|
|
||
| deleteTemplate := "https://vmwareengine.googleapis.com/v1/{{parent}}/externalAccessRules/{{name}}" | ||
| deleteUrl, err := tpgresource.ReplaceVars(d, config, deleteTemplate) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error preparing delete url: %s", err) | ||
| return nil | ||
| } | ||
| deleteUrl = deleteUrl + name | ||
|
|
||
| // Don't wait on operations as we may have a lot to delete | ||
| _, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{ | ||
| Config: config, | ||
| Method: "DELETE", | ||
| Project: config.Project, | ||
| RawURL: deleteUrl, | ||
| UserAgent: config.UserAgent, | ||
| }) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] Error deleting for url %s : %s", deleteUrl, err) | ||
| } else { | ||
| log.Printf("[INFO][SWEEPER_LOG] Sent delete request for %s resource: %s", resourceName, name) | ||
| } | ||
| } | ||
|
|
||
| if nonPrefixCount > 0 { | ||
| log.Printf("[INFO][SWEEPER_LOG] %d items were non-sweepable and skipped.", nonPrefixCount) | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| } |
145 changes: 145 additions & 0 deletions
145
...d_party/terraform/services/vmwareengine/resource_vmwareengine_external_address_sweeper.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package vmwareengine | ||
|
|
||
| import ( | ||
| "context" | ||
| "log" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform-provider-google/google/envvar" | ||
| "github.com/hashicorp/terraform-provider-google/google/sweeper" | ||
| "github.com/hashicorp/terraform-provider-google/google/tpgresource" | ||
| transport_tpg "github.com/hashicorp/terraform-provider-google/google/transport" | ||
| ) | ||
|
|
||
| func init() { | ||
| sweeper.AddTestSweepers("VmwareengineExternalAddress", testSweepVmwareengineExternalAddress) | ||
| } | ||
|
|
||
| // At the time of writing, the CI only passes us-central1 as the region | ||
| func testSweepVmwareengineExternalAddress(region string) error { | ||
| resourceName := "VmwareengineExternalAddress" | ||
| log.Printf("[INFO][SWEEPER_LOG] Starting sweeper for %s", resourceName) | ||
|
|
||
| config, err := sweeper.SharedConfigForRegion(region) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error getting shared config for region: %s", err) | ||
| return err | ||
| } | ||
|
|
||
| err = config.LoadAndValidate(context.Background()) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error loading: %s", err) | ||
| return err | ||
| } | ||
|
|
||
| t := &testing.T{} | ||
| billingId := envvar.GetTestBillingAccountFromEnv(t) | ||
|
|
||
| // List of location values includes: | ||
| // * zones used for this resource type's acc tests in the past | ||
| // * the 'region' passed to the sweeper | ||
| locations := []string{region, "us-central1-a", "us-central1-b", "southamerica-west1-a", "southamerica-west1-b", "me-west1-a", "me-west1-b"} | ||
| log.Printf("[INFO][SWEEPER_LOG] Sweeping will include these locations: %v.", locations) | ||
| for _, location := range locations { | ||
|
|
||
| // Setup variables to replace in list template | ||
| d := &tpgresource.ResourceDataMock{ | ||
| FieldsInSchema: map[string]interface{}{ | ||
| "project": config.Project, | ||
| "region": location, | ||
| "location": location, | ||
| "zone": location, | ||
| "billing_account": billingId, | ||
| "parent": "", // Set in loop below | ||
| }, | ||
| } | ||
|
|
||
| log.Printf("[INFO][SWEEPER_LOG] looking for parent resources in location '%s'.", location) | ||
|
|
||
| parentResponseField := "privateClouds" | ||
| parentListUrlTemplate := "https://vmwareengine.googleapis.com/v1/projects/{{project}}/locations/{{location}}/privateClouds" | ||
| parentNames, err := sweeper.ListParentResourcesInLocation(d, config, parentListUrlTemplate, parentResponseField) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error finding parental resources in location %s: %s", location, err) | ||
| continue | ||
| } | ||
| for _, parent := range parentNames { | ||
|
|
||
| // `parent` will be string of form projects/my-project/locations/us-central1-a/privateClouds/my-cloud | ||
| // Change on each loop, so new value used in tpgresource.ReplaceVars | ||
| d.Set("parent", parent) | ||
|
|
||
| listTemplate := "https://vmwareengine.googleapis.com/v1/{{parent}}/externalAddresses" | ||
| listUrl, err := tpgresource.ReplaceVars(d, config, listTemplate) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error preparing sweeper list url: %s", err) | ||
| continue | ||
| } | ||
|
|
||
| res, err := transport_tpg.SendRequest(transport_tpg.SendRequestOptions{ | ||
| Config: config, | ||
| Method: "GET", | ||
| Project: config.Project, | ||
| RawURL: listUrl, | ||
| UserAgent: config.UserAgent, | ||
| }) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] Error in response from request %s: %s", listUrl, err) | ||
| continue | ||
| } | ||
|
|
||
| resourceList, ok := res["externalAddresses"] | ||
| if !ok { | ||
| log.Printf("[INFO][SWEEPER_LOG] Nothing found in response.") | ||
| continue | ||
| } | ||
|
|
||
| rl := resourceList.([]interface{}) | ||
|
|
||
| log.Printf("[INFO][SWEEPER_LOG] Found %d items in %s list response.", len(rl), resourceName) | ||
| // Keep count of items that aren't sweepable for logging. | ||
| nonPrefixCount := 0 | ||
| for _, ri := range rl { | ||
| obj := ri.(map[string]interface{}) | ||
| if obj["name"] == nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] %s resource name was nil", resourceName) | ||
| continue | ||
| } | ||
|
|
||
| name := tpgresource.GetResourceNameFromSelfLink(obj["name"].(string)) | ||
| // Skip resources that shouldn't be sweeped | ||
| if !sweeper.IsSweepableTestResource(name) { | ||
| nonPrefixCount++ | ||
| continue | ||
| } | ||
|
|
||
| deleteTemplate := "https://vmwareengine.googleapis.com/v1/{{parent}}/externalAddresses/{{name}}" | ||
| deleteUrl, err := tpgresource.ReplaceVars(d, config, deleteTemplate) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] error preparing delete url: %s", err) | ||
| continue | ||
| } | ||
| deleteUrl = deleteUrl + name | ||
|
|
||
| // Don't wait on operations as we may have a lot to delete | ||
| _, err = transport_tpg.SendRequest(transport_tpg.SendRequestOptions{ | ||
| Config: config, | ||
| Method: "DELETE", | ||
| Project: config.Project, | ||
| RawURL: deleteUrl, | ||
| UserAgent: config.UserAgent, | ||
| }) | ||
| if err != nil { | ||
| log.Printf("[INFO][SWEEPER_LOG] Error deleting for url %s : %s", deleteUrl, err) | ||
| } else { | ||
| log.Printf("[INFO][SWEEPER_LOG] Sent delete request for %s resource: %s", resourceName, name) | ||
| } | ||
| } | ||
|
|
||
| if nonPrefixCount > 0 { | ||
| log.Printf("[INFO][SWEEPER_LOG] %d items were non-sweepable and skipped.", nonPrefixCount) | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| } |
Oops, something went wrong.