Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order links to orderHash not order IDs #1387

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Change order links to orderHash not order IDs #1387

wants to merge 11 commits into from

Conversation

hardingjam
Copy link
Contributor

@hardingjam hardingjam commented Feb 27, 2025 •
edited
Loading

  • This raises another issue about whether all order id use in rust should be hash instead. Since all sub-components of OrderDetail currently require the ID.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@hardingjam hardingjam requested a review from hardyjosh February 27, 2025 15:29
@hardingjam hardingjam self-assigned this Feb 27, 2025
@hardingjam hardingjam linked an issue Feb 27, 2025 that may be closed by this pull request
Link to order has order id in url, should be order-hash #1383
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

At least 1 approving review is required to merge this pull request.

Assignees

@hardingjam hardingjam

Labels
webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to order has order id in url, should be order-hash
1 participant
@hardingjam