Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node v14 test in CI #1311

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,16 @@ jobs:
node-version: ${{ matrix.node }}
cache: npm

# node v14 cannot install from current package-lock.json, so use npm install instea of npm ci.
# Cannot read property 'chalk' of undefined
# Regression: e88617964a009dbb9f5e973f64ff76ad289df68c
- name: Install npm dependencies
run: npm i
if: 'matrix.node == 14'

- name: Install npm dependencies
run: npm ci
if: 'matrix.node != 14'

- name: Build
run: npm run build
Expand Down
2 changes: 2 additions & 0 deletions .ncurc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,7 @@ module.exports = {
// Waiting for Prettier v3 support in @trivago/prettier-plugin-sort-imports
// https://github.com/trivago/prettier-plugin-sort-imports/issues/240
'prettier',
// Removed support for node v14 in v0.35.0
'makdownlint-cli',
],
}
45 changes: 18 additions & 27 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"eslint-plugin-promise": "^6.1.1",
"husky": "^8.0.3",
"lockfile-lint": "^4.10.6",
"markdownlint-cli": "^0.35.0",
"markdownlint-cli": "0.34.0",
"mocha": "^10.2.0",
"npm-run-all": "^4.1.5",
"prettier": "^2.8.8",
Expand Down
Loading