feat: bun as packageManager option

[ImBIOS]

@Jarred-Sumner @oven-sh need your help and review

[raineorshine]

Hi, thanks for the contribution. This looks good to me. Just need to get the tests passing.

[ImBIOS]

One file left needs some work, it's the bun package manager spawner file. I'm making this PR, but I do not yet understand the bare minimum requirement for that file.

[raineorshine]

The minimum packageManager file just needs a function to return the latest version:

{
  latest: (packageName: string,
  currentVersion: string) =>
    { error?: string, version?: number }
}

Additional targets (patch, minor, newest, greatest) can be added by defining their respective functions, which have the same signature. You may also consider defining a list function to add support for global mode.

The full PackageManager type is here: https://github.com/raineorshine/npm-check-updates/blob/main/src/types/PackageManager.ts

[ImBIOS]

@raineorshine I just implemented the basic bun spawner

[raineorshine]

You should spawn bun for the list command, as npm may have a different global install directory than bun.

Hopefully bun has a --json option, otherwise you'll have to parse the results.

[raineorshine]

Though there are some old tests remaining that operate on test files in the project directory tree, I prefer a dynamic setup in a temp directory as seen here:

npm-check-updates/test/bin.test.ts

Lines 115 to 128 in c7a339c

	it('read --packageFile', async () => {
	const stub = stubNpmView('99.9.9', { spawn: true })
	const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'npm-check-updates-'))
	const pkgFile = path.join(tempDir, 'package.json')
	await fs.writeFile(pkgFile, JSON.stringify({ dependencies: { express: '1' } }), 'utf-8')
	try {
	const text = await spawn('node', [bin, '--jsonUpgraded', '--packageFile', pkgFile])
	const pkgData = JSON.parse(text)
	pkgData.should.have.property('express')
	} finally {
	await fs.rm(tempDir, { recursive: true, force: true })
	stub.restore()
	}
	})

It makes the tests slightly more verbose, but I've found it easier to manage by having everything related to a test contained in the test file. Plus cleanup is easier because you can just delete the temp directory rather than having to do a precise restore.

[raineorshine]

Hi, have you had a chance to review the requested changes?

Just wanted to check in since some merge conflicts are accumulating as this sits.

[ImBIOS]

@raineorshine I've fixed the conflict and delivered 2 change requests. But, I have no idea how to deliver the other 2 requests you made. Can I request for your help?

[raineorshine]

I added the other targets (minor, patch, semver, greatest, newest), and implemented the list command which is needed for -g functionality. The bun cli does not have a --json option, so we just parse the cli output. Please see 15775ad for details.

Basic doctor mode works now. Also, I have bun installed conditionally in the CI environment and skip the tests on Windows.

I think we can merge this as an initial implementation. Additional functionality can be added in separate PR's. Let me know if there's anything else you'd like to add before I merge. Thanks!

[ImBIOS]

@raineorshine Nah, All good. Looks Good To Me. Thanks a lot for your help adding bun 🙏 😄