feat: remove scoped package / when pattern without / #1168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason for the screenshot is that
minimatch
treats/
as a directory.and if we want to update a scoped package, we must use a explicit slash like
*keyword*/*subkeyword*
a solution may be:
if provided pattern does not include a slash, and the dep is a scoped package with a slash.
then replace
/
with_
, so@scope/name
turns to@scope_name
, so that*
can finally match the "slash"an other solution may be, split the
@scope/name
and let split partial to match pattern,like