Support multiple --filter and --reject options (#1125).

raineorshine · Feb 22, 2023 · fa33af3 · fa33af3
1 parent 9636fdb
commit fa33af3
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/src/cli-options.ts b/src/cli-options.ts
@@ -427,6 +427,7 @@ const cliOptions: CLIOption[] = [
     description:
       'Include only package names matching the given string, wildcard, glob, comma-or-space-delimited list, /regex/, or predicate function.',
     type: 'string | string[] | RegExp | RegExp[] | FilterFunction',
+    parse: (value, accum) => [...(accum || []), value],
   },
   {
     long: 'filterVersion',
@@ -558,6 +559,7 @@ When --packageManager staticRegistry is set, --registry must specify a path to a
     description:
       'Exclude packages matching the given string, wildcard, glob, comma-or-space-delimited list, /regex/, or predicate function.',
     type: 'string | string[] | RegExp | RegExp[] | FilterFunction',
+    parse: (value, accum) => [...(accum || []), value],
   },
   {
     long: 'rejectVersion',

diff --git a/test/filter.test.ts b/test/filter.test.ts
@@ -272,6 +272,24 @@ describe('filter', () => {
       upgraded.should.have.property('lodash.map')
       upgraded.should.have.property('lodash.filter')
     })
+
+    it('allow multiple --filter options', async () => {
+      const pkgData = {
+        dependencies: {
+          'ncu-test-v2': '^1.0.0',
+          'ncu-test-tag': '^1.0.0',
+        },
+      }
+
+      const output = await spawn(
+        'node',
+        [bin, '--jsonUpgraded', '--stdin', '--filter', 'ncu-test-v2', '--filter', 'ncu-test-tag'],
+        JSON.stringify(pkgData),
+      )
+      const upgraded = JSON.parse(output)
+      upgraded.should.have.property('ncu-test-v2')
+      upgraded.should.have.property('ncu-test-tag')
+    })
   })
 })
 
@@ -309,5 +327,23 @@ describe('reject', () => {
       pkgData.should.have.property('ncu-test-v2')
       pkgData.should.have.property('ncu-test-tag')
     })
+
+    it('allow multiple --reject options', async () => {
+      const pkgData = {
+        dependencies: {
+          'ncu-test-v2': '^1.0.0',
+          'ncu-test-tag': '^1.0.0',
+        },
+      }
+
+      const output = await spawn(
+        'node',
+        [bin, '--jsonUpgraded', '--stdin', '--reject', 'ncu-test-v2', '--reject', 'ncu-test-tag'],
+        JSON.stringify(pkgData),
+      )
+      const upgraded = JSON.parse(output)
+      upgraded.should.not.have.property('ncu-test-v2')
+      upgraded.should.not.have.property('ncu-test-tag')
+    })
   })
 })