Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wrap / Unwrap #6026

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix Wrap / Unwrap #6026

merged 2 commits into from
Aug 21, 2024

Conversation

brunobar79
Copy link
Member

Fixes APP-####

What changed (plus any additional context for devs)

  • SDK bump supporting the right types for quotes
  • Make feeTokenAsset optional

Fixes the crash for WETH < = > ETH in release mode.

Screen recordings / screenshots

POW.mov

What to test

Wrap & Unwrap

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 merged commit 79be98c into develop Aug 21, 2024
2 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-wrap-unwrap branch August 21, 2024 14:33
brunobar79 added a commit that referenced this pull request Aug 21, 2024
* bump swaps sdk

* feeTokenAsset is optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants