Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing pricing swaps #6023

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

brunobar79
Copy link
Member

Fixes APP-####

What changed (plus any additional context for devs)

Reverting fallback usage of backend pricing till we can guarantee it's always coming back from BE.

Screen recordings / screenshots

Loading...

What to test

@@ -157,8 +157,6 @@ export function useFavorites(): {
const favoritesMetadata = query.data ?? {};
const favorites = Object.keys(favoritesMetadata);

console.log('favoritesMetadata', favoritesMetadata);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estebanmino straight to jail

@jinchung jinchung self-requested a review August 21, 2024 05:22
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@brunobar79 brunobar79 merged commit fe10fd7 into develop Aug 21, 2024
5 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-missing-pricing-swaps branch August 21, 2024 05:23
brunobar79 added a commit that referenced this pull request Aug 21, 2024
* fetch prices again until BE returns it

* clean log
Copy link

sentry-io bot commented Aug 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: [useSwapInputsController]: get asset prices failed <global>(src/logger/index) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants