Browser: catch up close button fixes with develop #5599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Tab transitions, add tab state update queue * Move unblocking to the end of setTabStatesThenUnblockQueue, remove some commented code * Remove commented code, adjust newTab checks * Make condition more readable Same logic but less confusing * Fix background color conversion * Remove redundant multipleTabsOpen logic, make conditions more legible * Fade in tabs on mount, clean up WebViewBorder * Fix part of the scroll jank * Queue logic cleanup, add some error logging TODOs * Catch up with develop * Remove unnecessary runOnJS * More performant fade in on mount * Lower fade duration * Lint --------- Co-authored-by: Christian Baroni <7061887+christianbaroni@users.noreply.github.com>
Also includes a few additional fixes
…christian/fix-close-tab-btn
christianbaroni
requested review from
brunobar79,
skylarbarrera and
benisgold
as code owners
…christian/fix-close-tab-btn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test