[FIX]: Increase number of pixel difference needed to qualify as non-gesture mode navigation #5460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/helpers/statusBarHelper.ts
Outdated
| @@ -34,5 +34,5 @@ export const isUsingButtonNavigation = () => { | |||
| const deviceHeight = Dimensions.get('screen').height; | |||
| const windowHeight = Dimensions.get('window').height; | |||
| const bottomNavBarHeight = deviceHeight - windowHeight; | |||
| return bottomNavBarHeight > 70; | |||
| return bottomNavBarHeight > 95; | |||
There was a problem hiding this comment.
any good way to not have this hardcoded? not sure exactly how this is being used
There was a problem hiding this comment.
not that I'm aware. There's probably a better way to check what navigation mode an Android user is using though..
There was a problem hiding this comment.
is this helper basically guessing whether the android has a soft nav bar or not? wondering if we can just get the nav bar height and return whether it's nonzero
benisgold
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test