analytics: fix identify calls

src/analytics/userProperties.ts

@@ -1,6 +1,9 @@
 import { NativeCurrencyKey } from '@/entities';
 import { Language } from '@/languages';
 
+// have to put this here or redux gets important and tests break
+type PushNotificationPermissionStatus = 'enabled' | 'disabled' | 'never asked';
+
 // these are all reported seperately so they must be optional
 export interface UserProperties {
   // settings
@@ -11,6 +14,7 @@ export interface UserProperties {
   enabledFlashbots?: boolean;
   pinnedCoins?: string[];
   hiddenCOins?: string[];
+  appIcon?: string;
 
   // assets
   NFTs?: number;
@@ -27,6 +31,11 @@ export interface UserProperties {
   numberOfFreeMints?: number;
   numberOfPaidMints?: number;
 
+  // notifications:
+  notificationsPermissionStatus?: PushNotificationPermissionStatus;
+  numberOfImportedWalletsWithNotificationsTurnedOn?: number;
+  numberOfWatchedWalletsWithNotificationsTurnedOn?: number;
+
   // ens
   // TODO: remove ensProfile tracking the entire object
   ensProfile?: Record<any, any>;

src/hooks/useTrackENSProfile.ts

@@ -2,7 +2,7 @@ import { useQuery } from '@tanstack/react-query';
 import { useCallback, useMemo } from 'react';
 import { fetchENSRecords } from './useENSRecords';
 import useWallets from './useWallets';
-import { analytics } from '@/analytics';
+import { analyticsV2 } from '@/analytics';
 import { EthereumAddress } from '@/entities';
 import { fetchAccountDomains } from '@/handlers/ens';
 import { ENS_RECORDS } from '@/helpers/ens';
@@ -56,7 +56,7 @@ export default function useTrackENSProfile() {
   });
 
   const trackENSProfile = useCallback(() => {
-    isSuccess && analytics.identify(undefined, data);
+    isSuccess && data && analyticsV2.identify(data);
   }, [isSuccess, data]);
 
   return { trackENSProfile };

src/notifications/analytics.ts

@@ -1,4 +1,4 @@
-import { analytics } from '@/analytics';
+import { analytics, analyticsV2 } from '@/analytics';
 import { MinimalNotification } from '@/notifications/types';
 import { getPermissionStatus } from '@/notifications/permissions';
 import messaging from '@react-native-firebase/messaging';
@@ -36,8 +36,8 @@ export const trackChangedNotificationSettings = (
   });
 };
 
-export const trackPushNotificationPermissionStatus = (status: PushNotificationPermissionStatus) => {
-  analytics.identify(undefined, { notificationsPermissionStatus: status });
+export const trackPushNotificationPermissionStatus = async (status: PushNotificationPermissionStatus) => {
+  analyticsV2.identify({ notificationsPermissionStatus: status });
 };
 
 type PushNotificationPermissionStatus = 'enabled' | 'disabled' | 'never asked';
@@ -130,8 +130,8 @@ const countWalletsWithNotificationsTurnedOn = (wallets: WalletNotificationSettin
   };
 };
 
-const trackNumberOfWalletsWithNotificationsTurnedOn = (imported: number, watched: number) => {
-  analytics.identify(undefined, {
+const trackNumberOfWalletsWithNotificationsTurnedOn = async (imported: number, watched: number) => {
+  analyticsV2.identify({
     numberOfImportedWalletsWithNotificationsTurnedOn: imported,
     numberOfWatchedWalletsWithNotificationsTurnedOn: watched,
   });

src/screens/WalletScreen/index.tsx

@@ -28,7 +28,7 @@ import { position } from '@/styles';
 import { Toast, ToastPositionContainer } from '@/components/toasts';
 import { useRecoilValue } from 'recoil';
 import { useSafeAreaInsets } from 'react-native-safe-area-context';
-import { analytics } from '@/analytics';
+import { analyticsV2 } from '@/analytics';
 import { AppState } from '@/redux/store';
 import { addressCopiedToastAtom } from '@/recoil/addressCopiedToastAtom';
 import { usePositions } from '@/resources/defi/PositionsQuery';
@@ -137,7 +137,7 @@ const WalletScreen: React.FC<any> = ({ navigation, route }) => {
 
   // track current app icon
   useEffect(() => {
-    analytics.identify(undefined, { appIcon });
+    analyticsV2.identify({ appIcon });
   }, [appIcon]);
 
   const isAddressCopiedToastActive = useRecoilValue(addressCopiedToastAtom);