Points: Fix total points not updating when switching wallets [ANDROID] #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisgold
requested review from
skylarbarrera,
jinchung,
walmat and
dereknelson
walmat
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-993
What changed (plus any additional context for devs)
Apparently the
maskElementprop ofMaskedViewdoes not rerender on android unless theandroidRenderingModeprop is set to"software". This was causing the total points display to not immediately update when switching wallets. If you switch tabs and return to the points tab, it displays the correct amount.see: react-native-masked-view/masked-view#132
Screen recordings / screenshots
https://www.loom.com/share/4aae0f4d260f41ffadb53cabc9038d24
What to test