-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rails 4.2 and Ruby 2.2 #140
Conversation
Looks like something wrong with travis ci env: http://monosnap.com/image/4XDVrDHdGmPByJIxqWJX9QlGwIzRpq Trying to check locally jruby and if all will be ok - will contact with travis ci support. |
Yep, something wrong with travis-ci: http://monosnap.com/image/jffOHFA0NhtgQnkZEGliOUuGyHrbo4 Chating with travis-ci support. |
Fixed, it was my mistake 😄 |
jruby-19mode using latest jruby, which is not stable. stable: jruby 1.7.18 (1.9.3p551). On travis: jruby 9.0.0.0-SNAPSHOT (2.2.0p0). I moved it in section "Allowed Failures". |
I've read a text in rails/rails#12178 It seems that this issue is pretty terrible to be in stable release. But we have no choice here. |
end | ||
# rails engine route | ||
if rails_engine_route.respond_to?(:superclass) && rails_engine_route.superclass == Rails::Engine && !route.path.anchored | ||
rails_engine_route.routes.named_routes.map do |_, engine_route| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets refactor this part a little bit. Are you sure you need a double check for respond_to?(:superclass)
? Lets extract a part of this code a method.
@bogdan yep, I also checking failing tests and found this issue. I made this pending more strict to rails 4.2.0. After release 4.2.1 we should remove this. |
Was noticed by this issue: #139