Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trailing slash #106

Merged
merged 3 commits into from
May 13, 2014
Merged

Support trailing slash #106

merged 3 commits into from
May 13, 2014

Conversation

le0pard
Copy link
Member

@le0pard le0pard commented May 12, 2014

By #105 request.

/cc @bogdan

@bogdan
Copy link
Collaborator

bogdan commented May 13, 2014

I think we should support it in the same way as rails:

site_path(1, :trailing_slash => true)  # => "/sites/1/"

In the same way we support :anchor for example.

So I would preffer the following behaviour:

expect(evaljs("Routes.inbox_path(1, {trailing_slash: true})")).to \
  eq(routes.inbox_path(1, trailing_slash: true)})

@le0pard
Copy link
Member Author

le0pard commented May 13, 2014

@bogdan Ok, will change this

@le0pard
Copy link
Member Author

le0pard commented May 13, 2014

@bogdan done, support in params and default_url_options.

bogdan added a commit that referenced this pull request May 13, 2014
@bogdan bogdan merged commit ac8216e into railsware:master May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants