-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds deploy script #322
base: master
Are you sure you want to change the base?
adds deploy script #322
Conversation
automating this might be risky in case it overrides BUILD_VARIANT by mistake. |
@salimhb if that is risky we might not want to do an automatically |
Yes, especially that pushing will deploy automatically. Instead of this script, I suggest adding these instructions in the README with a note about the environment variables. |
These branches are literally there only to set the BUILD_VARIANT (see the diff) |
Yes yes. I see that but I don't know if we need the environment variable. We can simply use git to get the branch name and do the build based on this. |
Adding a deploy script.
Maybe we should include a promotion in Semaphore too or instead of this?