Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds deploy script #322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adds deploy script #322

wants to merge 2 commits into from

Conversation

stringparser
Copy link
Contributor

@stringparser stringparser commented Sep 9, 2021

Adding a deploy script.

Maybe we should include a promotion in Semaphore too or instead of this?

@salimhb
Copy link
Member

salimhb commented Sep 9, 2021

automating this might be risky in case it overrides BUILD_VARIANT by mistake.

@bitboxer
Copy link
Contributor

bitboxer commented Sep 9, 2021

@salimhb if that is risky we might not want to do an automatically git push as part of this script?

@salimhb
Copy link
Member

salimhb commented Sep 10, 2021

@salimhb if that is risky we might not want to do an automatically git push as part of this script?

Yes, especially that pushing will deploy automatically. Instead of this script, I suggest adding these instructions in the README with a note about the environment variables.

@stringparser
Copy link
Contributor Author

@salimhb, @bitboxer Hm, not sure if I understand but builds are done in vercel right? Also I think if is this problematic we could use the branch to determine the build (no BUILD_VARIANT environment variable I mean).

@salimhb
Copy link
Member

salimhb commented Sep 10, 2021

These branches are literally there only to set the BUILD_VARIANT (see the diff)
If there's a way to handle this in Vercel, we wouldn't have needed these branches to start with ;)

@stringparser
Copy link
Contributor Author

These branches are literally there only to set the BUILD_VARIANT (see the diff)
If there's a way to handle this in Vercel, we wouldn't have needed these branches to start with ;)

Yes yes. I see that but I don't know if we need the environment variable. We can simply use git to get the branch name and do the build based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants