Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct meta tags syntax #3672

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

coorasse
Copy link
Contributor

@coorasse coorasse commented Feb 7, 2024

meta tags are void elements, so this is the correct syntax for them. See also: https://developer.mozilla.org/en-US/docs/Glossary/Void_element

meta tags are void elements, so this is the correct syntax for them. See also: https://developer.mozilla.org/en-US/docs/Glossary/Void_element
@coveralls
Copy link

Coverage Status

coverage: 95.9%. remained the same
when pulling 044289c on coorasse:patch-5
into af7414a on railsadminteam:master.

Copy link
Contributor

@codealchemy codealchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines -1 to +4
<meta content="IE=edge" http-equiv="X-UA-Compatible"/>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type"/>
<meta content="width=device-width, initial-scale=1" name="viewport; charset=utf-8"/>
<meta content="NONE,NOARCHIVE" name="robots"/>
<meta content="IE=edge" http-equiv="X-UA-Compatible">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<meta content="width=device-width, initial-scale=1" name="viewport; charset=utf-8">
<meta content="NONE,NOARCHIVE" name="robots">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the examples at https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#examples it uses the self-closing tags though:

image

@mshibuya mshibuya merged commit 06c9f5c into railsadminteam:master Mar 2, 2024
23 checks passed
@mshibuya
Copy link
Member

mshibuya commented Mar 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants