Added Collapsible Sidebar Menu #3198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From pulling latest change to branch in 462045f
codealchemy
reviewed
Nov 24, 2021
There was a problem hiding this comment.
@pavanagrawal thanks for the PR! I hope you don't mind my bringing in the latest changes here (rails_admin has since switched from TravisCI and there have been some recent updates that impact your changes as well). If this is something you're still interested in landing, it looks like there are a few minor issues to resolve beforehand (the Dropbox link is no longer working as well).
| @@ -43,7 +43,7 @@ | |||
| @import "rails_admin/ra.filtering-multiselect"; | |||
| @import "rails_admin/ra.widgets"; | |||
| @import "rails_admin/ra.sidescroll"; | |||
|
|
|||
| @import "rails_admin/ra.collapsible_sidebar"; | |||
There was a problem hiding this comment.
This seems to be the only issue affecting tests
# SassC::SyntaxError:
# Error: File to import not found or unreadable: rails_admin/ra.collapsible_sidebar.
Suggested change
| @import "rails_admin/ra.collapsible_sidebar"; |
Comment on lines
+1
to
+9
| $(function() { | ||
| $('.ra-menu-collapse').on('shown.bs.collapse', function () { | ||
| var target_obj = $("[data-menu-label-id*='"+$(this).attr('id')+"']"); | ||
| target_obj.html(target_obj.attr('data-menu-label') + ' -') | ||
| }).on('hidden.bs.collapse', function () { | ||
| var target_obj = $("[data-menu-label-id*='"+$(this).attr('id')+"']"); | ||
| target_obj.html(target_obj.attr('data-menu-label') + ' +') | ||
| }); | ||
| }); |
There was a problem hiding this comment.
prettier feedback
Suggested change
| $(function() { | |
| $('.ra-menu-collapse').on('shown.bs.collapse', function () { | |
| var target_obj = $("[data-menu-label-id*='"+$(this).attr('id')+"']"); | |
| target_obj.html(target_obj.attr('data-menu-label') + ' -') | |
| }).on('hidden.bs.collapse', function () { | |
| var target_obj = $("[data-menu-label-id*='"+$(this).attr('id')+"']"); | |
| target_obj.html(target_obj.attr('data-menu-label') + ' +') | |
| }); | |
| }); | |
| $(function () { | |
| $(".ra-menu-collapse") | |
| .on("shown.bs.collapse", function () { | |
| var target_obj = $("[data-menu-label-id*='" + $(this).attr("id") + "']"); | |
| target_obj.html(target_obj.attr("data-menu-label") + " -"); | |
| }) | |
| .on("hidden.bs.collapse", function () { | |
| var target_obj = $("[data-menu-label-id*='" + $(this).attr("id") + "']"); | |
| target_obj.html(target_obj.attr("data-menu-label") + " +"); | |
| }); | |
| }); |
If you could remove the jQuery from here as well, that would help progress towards #2893
mshibuya
added a commit
that referenced
this pull request
Aug 7, 2022
mshibuya
added a commit
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting Video : https://www.dropbox.com/s/ldlnxl32kyx0kgs/ra_collapsible_sidebar.mov?dl=0