Eager load has_one and has_many in the list view so they can be searched. #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4
changed the title
|
Always forcing eager load of |
| @@ -120,7 +120,7 @@ def check_for_cancel | |||
| end | |||
|
|
|||
| def get_collection(model_config, scope, pagination) | |||
| associations = model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name } | |||
| associations = model_config.list.fields.select { |f| f.type.in?([:belongs_to_association, :has_one_association, :has_many_association]) && !f.polymorphic? }.collect { |f| f.association.name } | |||
There was a problem hiding this comment.
is there another way we could do this?
There was a problem hiding this comment.
def get_collection(model_config, scope, pagination)
associations = _associations_for_collection(model_config)
# etc
end
def _associations_for_collection(model_config)
model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name }
endso that we can customize it?
bf4
pushed a commit
to bf4/rails_admin
that referenced
this pull request
Jun 6, 2016
e.g. it allows someone to [eager load has_one and has_many associations](railsadminteam#2441) without requiring a change in RailsAdmin: ```diff def get_associations_for_collection(model_config) - model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name } + model_config.list.fields.select { |f| f.type.in?([:belongs_to_association, :has_one_association, :has_many_association]) && !f.polymorphic? }.collect { |f| f.association.name } end ```
bf4
pushed a commit
to bf4/rails_admin
that referenced
this pull request
Jun 6, 2016
e.g. it allows someone to [eager load has_one and has_many associations](railsadminteam#2441) without requiring a change in RailsAdmin: ```diff def get_associations_for_collection(model_config) - model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name } + model_config.list.fields.select { |f| f.type.in?([:belongs_to_association, :has_one_association, :has_many_association]) && !f.polymorphic? }.collect { |f| f.association.name } end ```
bf4
pushed a commit
to bf4/rails_admin
that referenced
this pull request
Jun 6, 2016
e.g. it allows someone to [eager load has_one and has_many associations](railsadminteam#2441) without requiring a change in RailsAdmin: ```diff def get_associations_for_collection(model_config) - model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name } + model_config.list.fields.select { |f| f.type.in?([:belongs_to_association, :has_one_association, :has_many_association]) && !f.polymorphic? }.collect { |f| f.association.name } end ```
bf4
pushed a commit
to bf4/rails_admin
that referenced
this pull request
Jun 6, 2016
e.g. it allows someone to [eager load has_one and has_many associations](railsadminteam#2441) without requiring a change in RailsAdmin: ```diff def get_associations_for_collection(model_config) - model_config.list.fields.select { |f| f.type == :belongs_to_association && !f.polymorphic? }.collect { |f| f.association.name } + model_config.list.fields.select { |f| f.type.in?([:belongs_to_association, :has_one_association, :has_many_association]) && !f.polymorphic? }.collect { |f| f.association.name } end ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eager load has_one and has_many in the list view so they can be searched.