Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix css regression for has_one and has_many nested form #2337

Merged
merged 1 commit into from
Jun 30, 2015
Merged

Fix css regression for has_one and has_many nested form #2337

merged 1 commit into from
Jun 30, 2015

Conversation

dalpo
Copy link
Contributor

@dalpo dalpo commented Jun 19, 2015

Re-establish the margin below the has_may/has_one button as the boostrap2 version

Before

screenshot from 2015-06-19 19 07 10

After

screenshot from 2015-06-19 19 15 32

@rikkipitt
Copy link
Contributor

Well done! Looks good to me!

@luizpicolo
Copy link
Contributor

  • 1

@dalpo dalpo force-pushed the feature/fix-has-many-markup branch from 420e277 to 28e5e3e Compare June 30, 2015 09:02
@dalpo
Copy link
Contributor Author

dalpo commented Jun 30, 2015

Update:
I changed the @include clearfix, with a clear: both; for a better browser support.

mshibuya added a commit that referenced this pull request Jun 30, 2015
@mshibuya
Merge pull request #2337 from dalpo/feature/fix-has-many-markup
852dfb5 
Fix css regression for has_one and has_many nested form
@mshibuya mshibuya merged commit 852dfb5 into railsadminteam:master Jun 30, 2015
@mshibuya
Copy link
Member

Thanks! 😸

@dalpo
Copy link
Contributor Author

dalpo commented Jun 30, 2015

Thanks to you @mshibuya!! 😉
I'm waiting also for a your review of #2339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dalpo @rikkipitt @luizpicolo @mshibuya